Fix technical debt in trig element-wise function tests#2126
Merged
ndgrigorian merged 8 commits intomasterfrom Jul 23, 2025
Merged
Fix technical debt in trig element-wise function tests#2126ndgrigorian merged 8 commits intomasterfrom
ndgrigorian merged 8 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_69 ran successfully. |
8b4f079 to
de8c3ee
Compare
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_69 ran successfully. |
Collaborator
vtavana
reviewed
Jul 22, 2025
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_74 ran successfully. |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_75 ran successfully. |
vtavana
approved these changes
Jul 23, 2025
Contributor
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @ndgrigorian!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes removing a number of trig tests, and rewriting some
Some of these tests are redundant with other tests already present in the test suite, checking the outcome of generic parts of the element-wise function machinery (i.e., testing for identical output
usm_typeas input). Any arbitrary element-wise function could be used to check this machinery.Also removes all tests for complex special cases, as
cmathcannot be used without creating complicated logic in the test suitereintroducing or rewriting these tests for a smaller subset of complex special cases, and for each function individually, may be a step to take in a later PR, when further refactoring the test suite